Don't go negative in tui dimensions in collapsed sidebar#1598
Merged
krissetto merged 1 commit intodocker:mainfrom Feb 4, 2026
Merged
Don't go negative in tui dimensions in collapsed sidebar#1598krissetto merged 1 commit intodocker:mainfrom
krissetto merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
dgageot
approved these changes
Feb 4, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ No issues found - The defensive guards added to prevent negative TUI dimensions are implemented correctly.
The changes properly:
- Guard against negative values using
max(0, value) - Return early when dimensions are invalid
- Prevent potential panics from invalid array indexing or string operations
- Handle all edge cases appropriately
This is a solid defensive fix for the collapsed sidebar rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.