Merged
Conversation
Contributor
|
great, thanks @krissetto :) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review Summary
Found 1 resource leak issue in the changed code that should be addressed.
Issues Found
Resource Leak (Medium Severity): The session database connection created in createLocalRuntimeAndSession is not properly closed if subsequent operations fail.
Recommendation
The pattern used in pkg/acp/run.go (with deferred close) should be applied to cmd/root/run.go as well to ensure consistent resource management.
…sion-db flag Generally makes agent and session setup follow more the patterns used for the api and run commands Also forces tilde expansion on the run and api commands when passing the session-db as --session-db=~/somepath or --session-db "~/somepath" Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
acp-session-persistence
branch
from
ba8c8e5 to
a46f4e0
Compare
dgageot
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist ACP sessions to the default sqlite db unless specified with
--session-dbflagGenerally makes ACP agent and session setup follow more the patterns used for the
apiandruncommandsAlso fixes tilde expansion on the run command when specifying the session db as
--session-db=~/somepath.dbor--session-db "~/somepath.db"Fixes #1591