return error if no messages are available after conversion#1720
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 13, 2026
Merged
return error if no messages are available after conversion#1720dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
no need to send those requests to the provider since they are invalid Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ No issues found
The changes look good! The PR adds appropriate error handling to prevent invalid API calls when message conversion results in empty message lists. The implementation is:
- Correctly placed: Error checks happen after conversion but before API calls
- Clear messaging: Error messages are descriptive and actionable
- Well-tested: Comprehensive test coverage for nil messages, empty messages, system-only messages, and whitespace-only content
- Consistent: Same pattern applied to both
beta_client.goandclient.go
The error handling will prevent unnecessary API calls and provide clearer feedback when messages are filtered out during conversion.
dgageot
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need to send those requests to the provider since they are invalid