Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Found 2 issues in the refactored models store:
- HIGH SEVERITY:
sync.OnceValuespermanently caches errors, preventing retry/fallback logic from working after initial failures - MEDIUM SEVERITY: Context removal prevents cancellation of network/filesystem operations
The sync.OnceValues bug is critical and will cause permanent Store failures after any transient network issue on first access.
krissetto
approved these changes
Feb 13, 2026
| s.client = &http.Client{ | ||
| Timeout: 30 * time.Second, | ||
| } | ||
| cacheFile := filepath.Join(cacheDir, CacheFileName) |
Contributor
There was a problem hiding this comment.
do we need to cache to a file if the duration is the lifetime of the store?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.