Restore ctrl-r binding for searching prompt history#1759
Merged
rumpl merged 1 commit intodocker:mainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
✅ Approved - No issues found in the changed code.
This PR successfully restores the Ctrl+r binding for history search. The implementation:
- Properly adds the Ctrl+r key binding to the help display
- Correctly suppresses tab bar keys (Ctrl+n/Ctrl+p) during history search to allow cycling through matches
- Implements proper modal state handling for history search to capture keys before normal routing
- Includes appropriate conditional checks before entering history search mode
All type assertions follow the Bubble Tea component pattern where Update() and lifecycle methods always return valid model instances. The code is consistent with the existing codebase patterns.
rumpl
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes an oopsie
closes #1758