Skip to content

Fix path and typo#1788

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-1784
Feb 19, 2026
Merged

Fix path and typo#1788
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-1784

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Feb 19, 2026

Fixes #1784

Fixes docker#1784

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner February 19, 2026 09:05
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

No issues found - Changes look good!

This PR correctly:

  • Fixes the typo from workindgDir to workingDir throughout the file
  • Adds filepath.Join(t.workingDir, args.Path) in handleWriteFile, making it consistent with handleReadFile and handleEditFile

The changes ensure uniform path handling across all file operations and fix the naming issue referenced in #1784.

Copy link
Contributor

@trungutt trungutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@dgageot dgageot merged commit 060c2c2 into docker:main Feb 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[security] Inconsistent path handling enabling potential path traversal in file write operation

3 participants

Comments