Keep same error handling for main cli plugin execution#1789
Merged
gtardif merged 1 commit intodocker:mainfrom Feb 19, 2026
Merged
Keep same error handling for main cli plugin execution#1789gtardif merged 1 commit intodocker:mainfrom
gtardif merged 1 commit intodocker:mainfrom
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Found one inconsistency in the new error handling code. The change correctly mirrors the error handling pattern from PersistentPreRunE, but uses a different context reference that should be aligned for consistency.
The logic itself is correct for adding error handling to RunE, which was missing before. Good catch on the inconsistency in the PR description!
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
gtardif
force-pushed
the
fix_docker_agent_error_handling
branch
from
a663fc9 to
f16acc9
Compare
dgageot
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processError was invoked for preRun but not for Run when executing through docker cli plugin