allow .github and .gitlab directories in WalkFiles traversal#1833
allow .github and .gitlab directories in WalkFiles traversal#1833dgageot merged 1 commit intodocker:mainfrom
Conversation
689ac99 to
4d5018b
Compare
There was a problem hiding this comment.
Review Summary
Found one issue in the changed code: the modification to the hidden file/directory filtering logic now causes hidden files (not just directories) to be included in WalkFiles results when they should be skipped.
The original code would skip all hidden items (both files and directories) by returning from the condition early. The new code only applies the skip logic to directories, allowing hidden files like .gitignore, .env, .editorconfig, etc. to pass through and be collected at line 207.
Signed-off-by: maxcleme <maxime.clement@docker.com>
4d5018b to
bd35fbe
Compare
|
maybe we should guard against .env as a precaution |
|
This |
|
I don't think in claude code & friends they block it? |
|
@aheritier yeah true, and we did have similar things in place in cagent as well :) |
|
@krissetto Fwiw I do not have write permission here 😁 |
When working on CI it is super annoying to be not able to use
@with anything inside.github/folder.