Fix progress reporting for containerd pulls#1319
Merged
Merged
Conversation
During refactoring of the implementation PR progress reporting was broken. This gets the progress reporting back in action. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com> (cherry picked from commit 7f4c842) Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
Coverage 54.73% 54.73%
=======================================
Files 292 292
Lines 19267 19267
=======================================
Hits 10545 10545
Misses 8063 8063
Partials 659 659 |
vdemeester
approved these changes
Aug 29, 2018
vdemeester
left a comment
vdemeester
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🐯
That said, we tend to do the opposite (i.e. fixing in master, cherry-picking in the release branch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During refactoring of the implementation PR progress reporting
was broken. This gets the progress reporting back in action.
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com
(cherry picked from commit 7f4c842)
Signed-off-by: Daniel Hiltgen daniel.hiltgen@docker.com
Cherry-pick of #1311