Update Windows ico#2367
Merged
cpuguy83 merged 1 commit intodocker:masterfrom Mar 3, 2020
Merged
Conversation
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
Member
|
The |
Member
|
oh, never mind; the png is being deleted here, correct? |
Member
Author
|
Yes, it's deleted in that commit. GitHub somehow doesn't show that better for such removed binary files. |
thaJeztah
approved these changes
Mar 2, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM
I assume it automatically picks up the right file (so changes needed to use the .ico instead of the .png, correct?)
Member
Author
|
The relevant change is in the |
Member
|
Ah, interesting. Actually recall looking at that at some point, but wasn't sure if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #956
Signed-off-by: Stefan Scherer stefan.scherer@docker.com
- What I did
I've replaces the old Docker ico for the Windows exe files with a newer one.
I've also removed the
docker.pngfile as I couldn't find any reference where it may be used. Maybe that was only an example of the ico file for people unable to view Windows ico files.- How I did it
Picked it from an internal JIRA task. :-)
- How to verify it
Compile Windows
docker.exeand check it in Windows Explorer and Sysinternals Process Monitor.- Description for the changelog
Updated the Windows icon.
- A picture of a cute animal (not mandatory but encouraged)
See also moby/moby#40609