some minor cleanups#3978
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 9, 2023
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
rumpl
approved these changes
Jan 18, 2023
Member
Author
|
Hmm.. CI doesn't like it 😂 Possibly screwed up something somewhere; I'll check when I'm back at my computer |
thaJeztah
force-pushed
the
minor_cleanups
branch
from
98178c8 to
8468eef
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3978 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 288 288
Lines 24776 24776
=======================================
Hits 14627 14627
Misses 9265 9265
Partials 884 884 |
- containerConfig collided with the containerConfig type - warning collided with the warning const Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
minor_cleanups
branch
from
8468eef to
f36e4b0
Compare
Member
Author
|
dropped the first commit for now; all green; bringing this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had these in a branch I'm working on, but they were not directly related, so opening a PR to get these changes out of the way.