Skip to content

[20.10 backport] Enable ssh forwarding when building a remote target#4115

Closed
crazy-max wants to merge 1 commit intodocker:20.10from
crazy-max:20.10_backport_enable-ssh-when-accessing-git-url
Closed

[20.10 backport] Enable ssh forwarding when building a remote target#4115
crazy-max wants to merge 1 commit intodocker:20.10from
crazy-max:20.10_backport_enable-ssh-when-accessing-git-url

Conversation

@crazy-max
Copy link
Copy Markdown
Member

- this fixes moby/buildkit#2040 by enabling
ssh forwarding when a remote address is given on the command line, this
is a similar fix to docker/buildx#581

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
(cherry picked from commit af1bb80)
@crazy-max
Copy link
Copy Markdown
Member Author

Looks like it needs a vendoring pass: https://ci-next.docker.com/public/blue/organizations/jenkins/cli/detail/PR-4115/1/pipeline#step-22-log-224

#14 [10/11] RUN ./scripts/build/binary
#14 0.580 Building static docker-linux-amd64
#14 1.631 cli/command/image/build_buildkit.go:33:2: cannot find package "github.com/moby/buildkit/util/gitutil" in any of:
#14 1.631 	/go/src/github.com/docker/cli/vendor/github.com/moby/buildkit/util/gitutil (vendor tree)
#14 1.631 	/usr/local/go/src/github.com/moby/buildkit/util/gitutil (from $GOROOT)
#14 1.631 	/go/src/github.com/moby/buildkit/util/gitutil (from $GOPATH)
#14 ERROR: process "/bin/sh -c ./scripts/build/binary" did not complete successfully: exit code: 1

@crazy-max
Copy link
Copy Markdown
Member Author

Actually it needs moby/buildkit#2056 to be backported to BuildKit v0.8 branch so might not be worth it to backport this change.

@thaJeztah thaJeztah added this to the 20.10.24 milestone Mar 28, 2023
@thaJeztah thaJeztah marked this pull request as draft March 31, 2023 18:35
@thaJeztah thaJeztah modified the milestones: 20.10.24, 20.10.25 Apr 4, 2023
@thaJeztah thaJeztah modified the milestones: 20.10.25, 20.10.26 Apr 27, 2023
@thaJeztah thaJeztah removed this from the 20.10.26 milestone Jul 20, 2023
@thaJeztah thaJeztah closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants