[20.10 backport] Enable ssh forwarding when building a remote target#4115
Closed
crazy-max wants to merge 1 commit intodocker:20.10from
Closed
[20.10 backport] Enable ssh forwarding when building a remote target#4115crazy-max wants to merge 1 commit intodocker:20.10from
crazy-max wants to merge 1 commit intodocker:20.10from
Conversation
- this fixes moby/buildkit#2040 by enabling ssh forwarding when a remote address is given on the command line, this is a similar fix to docker/buildx#581 Signed-off-by: Alex Couture-Beil <alex@earthly.dev> (cherry picked from commit af1bb80)
Member
Author
|
Looks like it needs a vendoring pass: https://ci-next.docker.com/public/blue/organizations/jenkins/cli/detail/PR-4115/1/pipeline#step-22-log-224 |
Member
Author
|
Actually it needs moby/buildkit#2056 to be backported to BuildKit v0.8 branch so might not be worth it to backport this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4112
cc @thaJeztah