cli/streams: minor refactoring and docs touch-ups#4153
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 3, 2023
Merged
cli/streams: minor refactoring and docs touch-ups#4153thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4153 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 287 287
Lines 24767 24767
=======================================
Hits 14620 14620
Misses 9264 9264
Partials 883 883 |
vvoland
approved these changes
Apr 3, 2023
| ws, err := term.GetWinsize(o.fd) | ||
| if err != nil { | ||
| logrus.Debugf("Error getting size: %s", err) | ||
| logrus.WithError(err).Debugf("Error getting TTY size") |
Member
Author
There was a problem hiding this comment.
doh! good catch. Let me update
- Touch-up GoDoc to better document each method, adding punctuation, and use doc-links where applicable. - SetRawTerminal(): change the order in which we check if a terminal is connected; check the local boolean first before checking if the NORAW env-var is set. - NewOut() / NewIn(); remove intermediate variables - Remove explicit use of the embedded "commonStream" to make the code slightly less verbose, and more "to the point". - Document the intended purpose of SetIsTerminal(), which was added in moby/moby@b2551c6 to be used in unit-tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
streams_cleanup
branch
from
555c8f4 to
8080326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)