Skip to content

docs: update engine versions in some examples#4179

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:no_2206
Apr 10, 2023
Merged

docs: update engine versions in some examples#4179
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:no_2206

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #4179 (5d33b72) into master (5acb649) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4179   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files         288      288           
  Lines       24776    24776           
=======================================
  Hits        14627    14627           
  Misses       9265     9265           
  Partials      884      884           

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
$ docker version --format '{{json .}}'

{"Client":{"Platform":{"Name":"Docker Engine - Community"},"Version":"19.03.8","ApiVersion":"1.40","DefaultAPIVersion":"1.40","GitCommit":"afacb8b","GoVersion":"go1.12.17","Os":"darwin","Arch":"amd64","BuildTime":"Wed Mar 11 01:21:11 2020","Experimental":true},"Server":{"Platform":{"Name":"Docker Engine - Community"},"Components":[{"Name":"Engine","Version":"19.03.8","Details":{"ApiVersion":"1.40","Arch":"amd64","BuildTime":"Wed Mar 11 01:29:16 2020","Experimental":"true","GitCommit":"afacb8b","GoVersion":"go1.12.17","KernelVersion":"4.19.76-linuxkit","MinAPIVersion":"1.12","Os":"linux"}},{"Name":"containerd","Version":"v1.2.13","Details":{"GitCommit":"7ad184331fa3e55e52b890ea95e65ba581ae3429"}},{"Name":"runc","Version":"1.0.0-rc10","Details":{"GitCommit":"dc9208a3303feef5b3839f4323d9beb36df0a9dd"}},{"Name":"docker-init","Version":"0.18.0","Details":{"GitCommit":"fec3683"}}],"Version":"19.03.8","ApiVersion":"1.40","MinAPIVersion":"1.12","GitCommit":"afacb8b","GoVersion":"go1.12.17","Os":"linux","Arch":"amd64","KernelVersion":"4.19.76-linuxkit","Experimental":true,"BuildTime":"2020-03-11T01:29:16.000000000+00:00"}}
{"Client":"Version":"23.0.3","ApiVersion":"1.42", ...}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truncated these examples, as they're really long, and the output is only to illustrate that it's outputting the information in JSON format.

Comment thread man/src/version.md
Comment on lines +8 to +9
The default output renders all version information divided into two sections;
the "Client" section contains information about the Docker CLI and client
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly aligning this content more with the online reference (although there's parts not yet included in the man-pages. I left that for a later exercise).

@thaJeztah
Copy link
Copy Markdown
Member Author

@dvdksn PTAL 🤗

Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Thanks! Let me bring this one in, and move the backport out of draft

@thaJeztah thaJeztah merged commit fff5a31 into docker:master Apr 10, 2023
@thaJeztah thaJeztah deleted the no_2206 branch April 10, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants