Skip to content

vendor: github.com/moby/term v0.5.0#4248

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:update_moby_term
May 3, 2023
Merged

vendor: github.com/moby/term v0.5.0#4248
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:update_moby_term

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

  • split exported functions from implementation
  • windows: IsConsole(): fix deprecation comment
  • deprecate Termios in favor of unix.Termios
  • windows: keyToString(): fix string conversion
  • gha: update actions, add macOS, and add Go1.20
  • gha: add windows

full diff: moby/term@c43b287...v0.5.0

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

- split exported functions from implementation
- windows: IsConsole(): fix deprecation comment
- deprecate Termios in favor of unix.Termios
- windows: keyToString(): fix string conversion
- gha: update actions, add macOS, and add Go1.20
- gha: add windows

full diff: moby/term@c43b287...v0.5.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 24.0.0 milestone May 2, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2023

Codecov Report

Merging #4248 (f233bec) into master (afd320c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4248   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files         570      570           
  Lines       49558    49558           
=======================================
  Hits        29178    29178           
  Misses      18616    18616           
  Partials     1764     1764           

@thaJeztah
Copy link
Copy Markdown
Member Author

@rumpl @laurazard ptal

@thaJeztah thaJeztah merged commit 7d72214 into docker:master May 3, 2023
@thaJeztah thaJeztah deleted the update_moby_term branch May 3, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants