Skip to content

cli/context/docker: Endpoint.ClientOpts, withHTTPClient: inline variables#4427

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:context_inline_vars
Jul 17, 2023
Merged

cli/context/docker: Endpoint.ClientOpts, withHTTPClient: inline variables#4427
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:context_inline_vars

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Remove some intermediate variables, and inline them.

- A picture of a cute animal (not mandatory but encouraged)

…bles

Remove some intermediate variables, and inline them.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review area/context kind/refactor PR's that refactor, or clean-up code labels Jul 15, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4427 (223bf80) into master (6654ea1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4427   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         288      288           
  Lines       24778    24778           
=======================================
  Hits        14719    14719           
  Misses       9173     9173           
  Partials      886      886           

Copy link
Copy Markdown
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 25.0.0 milestone Jul 17, 2023
@thaJeztah thaJeztah merged commit ce9f15c into docker:master Jul 17, 2023
@thaJeztah thaJeztah deleted the context_inline_vars branch July 17, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/context kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants