Skip to content

ignore#4449

Merged
thaJeztah merged 1 commit intodocker:masterfrom
vvoland:fix-issue-4414-Danial-Gharib-24
Jul 19, 2023
Merged

ignore#4449
thaJeztah merged 1 commit intodocker:masterfrom
vvoland:fix-issue-4414-Danial-Gharib-24

Conversation

@vvoland
Copy link
Copy Markdown
Collaborator

@vvoland vvoland commented Jul 19, 2023

Initialize AuthConfigs map if it's nil before returning it. This fixes fileStore.Store nil dereference panic when adding a new key to the map.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Initialize AuthConfigs map if it's nil before returning it.
This fixes fileStore.Store nil dereference panic when adding a new key
to the map.

Signed-off-by: Danial Gharib <danial.mail.gh@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 24.0.5 milestone Jul 19, 2023
@thaJeztah thaJeztah merged commit 4f67ff8 into docker:master Jul 19, 2023
@thaJeztah
Copy link
Copy Markdown
Member

OH LOL; looks like you opened the "backport" against "master", so it didn't backport

@thaJeztah thaJeztah changed the title [24.0 backport] Fix nil pointer dereference issue (#4414) ignore Jul 19, 2023
@thaJeztah thaJeztah removed this from the 24.0.5 milestone Jul 19, 2023
@neersighted
Copy link
Copy Markdown
Member

(This was not actually merged; since this had the same contents as the merged PR, GitHub's UI considers it merged)

@thaJeztah thaJeztah added this to the 25.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants