[23.0 backport] configfile: Initialize nil AuthConfigs#4451
Merged
thaJeztah merged 1 commit intodocker:23.0from Jul 19, 2023
Merged
[23.0 backport] configfile: Initialize nil AuthConfigs#4451thaJeztah merged 1 commit intodocker:23.0from
thaJeztah merged 1 commit intodocker:23.0from
Conversation
Initialize AuthConfigs map if it's nil before returning it. This fixes fileStore.Store nil dereference panic when adding a new key to the map. Signed-off-by: Danial Gharib <danial.mail.gh@gmail.com> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit ad43df5)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 23.0 #4451 +/- ##
==========================================
- Coverage 59.02% 59.01% -0.01%
==========================================
Files 288 288
Lines 24820 24824 +4
==========================================
+ Hits 14650 14651 +1
- Misses 9284 9286 +2
- Partials 886 887 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize AuthConfigs map if it's nil before returning it. This fixes fileStore.Store nil dereference panic when adding a new key to the map.
Signed-off-by: Danial Gharib danial.mail.gh@gmail.com
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com
(cherry picked from commit ad43df5)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)