Skip to content

[20.10 backport] configfile: Initialize nil AuthConfigs#4452

Merged
thaJeztah merged 1 commit intodocker:20.10from
vvoland:fix-issue-4414-Danial-Gharib-2010
Jul 19, 2023
Merged

[20.10 backport] configfile: Initialize nil AuthConfigs#4452
thaJeztah merged 1 commit intodocker:20.10from
vvoland:fix-issue-4414-Danial-Gharib-2010

Conversation

@vvoland
Copy link
Copy Markdown
Collaborator

@vvoland vvoland commented Jul 19, 2023

Initialize AuthConfigs map if it's nil before returning it. This fixes fileStore.Store nil dereference panic when adding a new key to the map.

Signed-off-by: Danial Gharib danial.mail.gh@gmail.com
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com
(cherry picked from commit ad43df5)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Initialize AuthConfigs map if it's nil before returning it.
This fixes fileStore.Store nil dereference panic when adding a new key
to the map.

Signed-off-by: Danial Gharib <danial.mail.gh@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit ad43df5)
@vvoland vvoland added this to the 20.10.26 milestone Jul 19, 2023
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 4b0940b into docker:20.10 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants