Updated docs for --env-file comments handling#4642
Merged
thaJeztah merged 1 commit intodocker:masterfrom Nov 7, 2023
Merged
Conversation
Signed-off-by: Saurabh Kumar <saurabhkumar0184@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Oh! Actually ignore my previous comment; looks like it's complaining about the name not matching your Git config 🤔
I can mark it to pass |
Contributor
Author
|
Thank you for reviewing my first PR. I'm excited to contribute to Docker, but I'm still learning the ropes. If there's anything specific I should do or consider, please let me know. |
desmond3th
changed the title
dvdksn
approved these changes
Nov 7, 2023
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
LGTM! Thank you @desmond3th
Contributor
Author
|
Thank you so much for merging my first PR. I look forward to making more contributions in the future. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--env-filedoesn't support inline comments #4404- What I did
Updated the documentation to clarify how comments are handled when using the --env-file option.
- How I did it
Made changes in run.md file.
- Description for the changelog
Improved documentation clarity regarding --env-file comments handling.
- A picture of a cute animal (not mandatory but encouraged)