exec.md: remove misleading part#4689
Merged
thaJeztah merged 1 commit intodocker:masterfrom Dec 1, 2023
Merged
Conversation
"By default" implies that this is something which could be disabled for an individual `docker exec` call. This doesn't seem to be the case, so removing the "by default" part would make these docs clearer to me. Signed-off-by: Per Lundberg <per.lundberg@hibox.tv>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4689 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 287 287
Lines 24821 24821
=======================================
Hits 14832 14832
Misses 9103 9103
Partials 886 886 |
thaJeztah
approved these changes
Dec 1, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Ah, yes, that reads a lot better. Thanks for contributing!
LGTM
Contributor
Author
|
Thanks yourself @thaJeztah for the warm welcome back, and for very fast turnaround on this. 🙇 Appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"By default" implies that this is something which could be disabled for an individual
docker execcall. This doesn't seem to be the case, so removing the "by default" part would make these docs clearer to me.