Do not underline image name #5473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blue text with underline looks too much as a hyperlink I can click on Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5473 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 345 345
Lines 23431 23431
=======================================
Hits 13999 13999
Misses 8458 8458
Partials 974 974 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
laurazard
approved these changes
Sep 23, 2024
Collaborator
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
Nice! I like it better too :)
thaJeztah
approved these changes
Sep 23, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM 👍 was considering this as well
thaJeztah
added
the
containerd-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed the underline from the blue image names. Blue text with underline looks too much as a hyperlink I can click on
Before:
After:
- How I did it
...
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)