docs: update prose about image tag/name format#5535
Merged
vvoland merged 1 commit intodocker:masterfrom Oct 17, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5535 +/- ##
==========================================
+ Coverage 60.67% 60.92% +0.25%
==========================================
Files 345 345
Lines 23491 23491
==========================================
+ Hits 14252 14313 +61
+ Misses 8266 8205 -61
Partials 973 973 |
laurazard
approved these changes
Oct 14, 2024
Member
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
This looks fantastic! Thanks 🤗
dvdksn
force-pushed
the
fix-image-tag-spec
branch
from
389dc26 to
a1ca594
Compare
vvoland
approved these changes
Oct 17, 2024
vvoland
reviewed
Oct 17, 2024
Collaborator
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
Actually.. Maybe we should use the term image reference instead of image name?
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
fix-image-tag-spec
branch
from
a1ca594 to
2c6b804
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Update the verbiage about the format of image tags/names.
- How I did it
/usr/bin/nvim
- How to verify it
read it
- A picture of a cute animal (not mandatory but encouraged)