Skip to content

cli/command/system: don't use "non-distributable-artifacts" fields in tests#5679

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:remove_use_of_nondistributable_artifacts
Dec 9, 2024
Merged

cli/command/system: don't use "non-distributable-artifacts" fields in tests#5679
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:remove_use_of_nondistributable_artifacts

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Nondistributable artifacts are deprecated, and no longer used; we'll be deprecating these fields, so let's already skip their use.

- A picture of a cute animal (not mandatory but encouraged)

… tests

Nondistributable artifacts are deprecated, and no longer used; we'll be
deprecating these fields, so let's already skip their use.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 28.0.0 milestone Dec 7, 2024
@thaJeztah thaJeztah self-assigned this Dec 7, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (66dfe6d) to head (b51a711).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5679   +/-   ##
=======================================
  Coverage   59.50%   59.50%           
=======================================
  Files         346      346           
  Lines       29367    29367           
=======================================
  Hits        17474    17474           
  Misses      10920    10920           
  Partials      973      973           

Copy link
Copy Markdown
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 395716b into docker:master Dec 9, 2024
@thaJeztah thaJeztah deleted the remove_use_of_nondistributable_artifacts branch December 9, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants