Skip to content

Drop support for fluentd-async-connect #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 2 commits into from
Jan 13, 2025
Merged

Drop support for fluentd-async-connect #5740

thaJeztah merged 2 commits into from
Jan 13, 2025

Conversation

@akerouanton
Copy link
Member

@akerouanton akerouanton commented Jan 13, 2025

Related to:

- What I did

  • Update completion scripts to autocomplete the newer option fluentd-async instead of fluentd-async-connect.
  • Update the list of deprecated Engine features to mark fluentd-async-connect as removed.

@akerouanton
docs: mark logger opt 'fluentd-async-connect' as removed
3da5f58 
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton
completion: replace fluentd-async-connect with fluentd-async
acbdad9 
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton akerouanton added this to the 28.0.0 milestone Jan 13, 2025
@akerouanton akerouanton self-assigned this Jan 13, 2025
@akerouanton akerouanton requested review from a team, albers and thaJeztah as code owners January 13, 2025 17:44
@akerouanton akerouanton mentioned this pull request Jan 13, 2025
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.80%. Comparing base (d4db289) to head (acbdad9).
Report is 104 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
+ Coverage   59.53%   59.80%   +0.26%     
==========================================
  Files         346      346              
  Lines       29365    29606     +241     
==========================================
+ Hits        17483    17706     +223     
- Misses      10911    10920       +9     
- Partials      971      980       +9

thaJeztah
thaJeztah approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit dbc5cf6 into docker:master Jan 13, 2025
101 checks passed
@akerouanton akerouanton deleted the fluentd-async-connect-removal branch January 13, 2025 19:04
@thaJeztah thaJeztah mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@albers albers Awaiting requested review from albers albers is a code owner

Assignees

@akerouanton akerouanton

Labels

kind/docs status/3-docs-review

Projects

None yet

Milestone

28.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@akerouanton @codecov-commenter @thaJeztah