cli/command: update semconv to 1.26.0#5751
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jan 14, 2025
Merged
Conversation
Align the version with what's used by buildkit. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5751 +/- ##
=======================================
Coverage 59.51% 59.51%
=======================================
Files 346 346
Lines 29376 29376
=======================================
Hits 17483 17483
Misses 10923 10923
Partials 970 970 |
vvoland
approved these changes
Jan 14, 2025
thaJeztah
commented
Jan 14, 2025
| @@ -326,7 +326,6 @@ go.opentelemetry.io/otel/internal/baggage | |||
| go.opentelemetry.io/otel/internal/global | |||
| go.opentelemetry.io/otel/propagation | |||
| go.opentelemetry.io/otel/semconv/v1.20.0 | |||
Member
Author
There was a problem hiding this comment.
Looks like the remaining users of v1.20;
instrumentation/net/http/otelhttp; updating in instrumentation/net/http/otelhttp: upgrade semconv to v1.26.0 open-telemetry/opentelemetry-go-contrib#5923, but not yet released?- containerd? (not a dendency of docker/cli)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the version with what's used by buildkit.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)