small performance optimizations for running hooks#5893
Merged
thaJeztah merged 2 commits intodocker:masterfrom Mar 5, 2025
Merged
small performance optimizations for running hooks#5893thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah merged 2 commits intodocker:masterfrom
Conversation
Order conditions to check for lightweight ones first; - checck if the command is not nil - dockerCli.Out().IsTerminal() is a lightweight getter - dockerCli.HooksEnabled() checks for env-vars, parses booleans, and reading the CLI config-file Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The DOCKER_CLI_HINTS env-var is replaced by DOCKER_CLI_HOOKS; check the new env-var first, and only fall back to checking the legacy env-var if it's not set. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5893 +/- ##
=======================================
Coverage 59.29% 59.29%
=======================================
Files 355 355
Lines 29753 29753
=======================================
Hits 17641 17641
Misses 11140 11140
Partials 972 972 |
vvoland
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/docker: small performance optimizations for running hooks
Order conditions to check for lightweight ones first;
reading the CLI config-file
cli/command: DockerCli.HooksEnabled check current before legacy
The DOCKER_CLI_HINTS env-var is replaced by DOCKER_CLI_HOOKS; check the
new env-var first, and only fall back to checking the legacy env-var
if it's not set.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)