Skip to content

cli/command/image: fix some minor linting issues#5911

Merged
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:builder_nits
Mar 10, 2025
Merged

cli/command/image: fix some minor linting issues#5911
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:builder_nits

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 8, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (2eec746) to head (2c0f9f4).
Report is 22 commits behind head on master.

❌ Your patch status has failed because the patch coverage (35.29%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5911   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files         357      357           
  Lines       29771    29771           
=======================================
  Hits        17645    17645           
  Misses      11153    11153           
  Partials      973      973           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah thaJeztah merged commit 879acd1 into docker:master Mar 10, 2025
@thaJeztah thaJeztah deleted the builder_nits branch March 10, 2025 15:12
@thaJeztah thaJeztah self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants