cli/command: PruneFilters: require smaller interface#5917
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 10, 2025
Merged
cli/command: PruneFilters: require smaller interface#5917thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
This function only needs access to the CLI's configfile; use the config.Prider interface to be more clear on what's expected. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5917 +/- ##
==========================================
- Coverage 59.26% 59.26% -0.01%
==========================================
Files 357 357
Lines 29771 29772 +1
==========================================
Hits 17645 17645
- Misses 11153 11154 +1
Partials 973 973 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function only needs access to the CLI's configfile; use the config.Prider interface to be more clear on what's expected.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)