Skip to content

Conversation

@thaJeztah
Copy link
Member

Alternatively, we could add another build-tag, but this probably is less impactful.

vendor/github.com/docker/cli/cli/command/formatter/displayutils.go:78:20: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah
Copy link
Member Author

Ah. Derp. Linter doesn't agree;

0.74 cli/command/formatter/displayutils.go:78:20: use-any: since Go 1.18 'interface{}' can be replaced by 'any' (revive)
70.74 func PrettyPrint(i interface{}) string {

Ok; build-tags it is then

Seen failing when used elsewhere;

    vendor/github.com/docker/cli/cli/command/formatter/displayutils.go:78:20: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title cli/command/formatter: use interface instead of any cli/command/formatter: add missing go:build tag Mar 10, 2025
@thaJeztah thaJeztah requested a review from Benehiko March 10, 2025 17:04
@thaJeztah thaJeztah merged commit 3d3f780 into docker:master Mar 10, 2025
90 checks passed
@thaJeztah thaJeztah deleted the no_generics branch March 10, 2025 17:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (571124d) to head (2cd4786).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5919   +/-   ##
=======================================
  Coverage   59.27%   59.27%           
=======================================
  Files         358      358           
  Lines       29772    29772           
=======================================
  Hits        17648    17648           
  Misses      11152    11152           
  Partials      972      972           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants