Skip to content

cli/command: inline vars and use struct literals in formatting functions #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 11 commits into from
Aug 22, 2025
Merged

cli/command: inline vars and use struct literals in formatting functions #6338

thaJeztah merged 11 commits into from
Aug 22, 2025

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 22, 2025

- Human readable description for the release notes



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
        

    

  
  

  
          thaJeztah
  

        added 11 commits
        August 22, 2025 09:19


  

      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/network: formatWrite: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          7589722
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/image: historyWrite: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          8cb8056
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/checkpoint: formatWrite: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          70033b7
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/config: formatWrite: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          3d2bd97
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/node: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          1a433cd
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/plugin: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          aa39a7e
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/registry: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          863b563
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/secret: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          12d30bb
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/service: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          e308036
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/task: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          6de2cdd
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          cli/command/trust: inline vars and use struct literals
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          f72ec26
        
      

    

  

    

      
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







  








      

  
            

    

      
    

    


      


          @thaJeztah
thaJeztah




            added
      

  status/2-code-review


      

  kind/refactor

  PR's that refactor, or clean-up code

  labels


      Aug 22, 2025

    

  



    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  29.0.0 milestone


      Aug 22, 2025

    

  








      

  
      



  

  @codecov-commenter






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        



        

    

  


  

    

      
          
      

      
            codecov-commenter
  

      

      

      commented


        Aug 22, 2025


      
    


  





      


        



  
    

      
          
Codecov Report


❌ Patch coverage is 98.83041% with 2 lines in your changes missing coverage. Please review.






Files with missing lines
Patch %
Lines






cli/command/image/formatter_history.go
94.44%
0 Missing and 1 partial ⚠️ 




cli/command/service/formatter.go
80.00%
0 Missing and 1 partial ⚠️ 






📢 Thoughts on this report? Let us know!


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @thaJeztah
  thaJeztah


        marked this pull request as draft

    August 22, 2025 07:47    
    




  

  
  

  
      @thaJeztah
  thaJeztah


        marked this pull request as ready for review

    August 22, 2025 10:10    
    









      

  
        





      

  
          
 
  

    
  

  


        
        @thaJeztah
  thaJeztah



        merged commit 4d4533a
      into

      
  
    docker:master
  


    Aug 22, 2025

      

        111 of 112 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        cleanup_formatters
    
    branch

    August 22, 2025 10:25    
    













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


      
  

    


  
      @Benehiko
  
    Benehiko



    
      
        
      
    
    Benehiko approved these changes

  



      






    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    kind/refactor

  PR's that refactor, or clean-up code
  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    29.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @thaJeztah 
        
          @codecov-commenter 
        
          @Benehiko