Skip to content

Conversation

@austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Sep 24, 2025

- What I did

Vendors tip of github.com/docker/docker@28.x

- How I did it

go get -u github.com/docker/docker@28.x
go mod tidy && go mod vendor

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@austinvazquez
Copy link
Contributor Author

=== FAIL: e2e/registry TestOauthLogin (1.02s)
login_test.go:28: terminating PID 10086
login_test.go:33: assertion failed: expression is false: strings.Contains(string(output), "USING WEB-BASED LOGIN"): Failed to start web-based login - falling back to command line login...

   Log in with your Docker ID or email address to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com/ to create one.
   You can log in with your password or a Personal Access Token (PAT). Using a limited-scope PAT grants better security and is required for organizations using SSO. Learn more at https://docs.docker.com/go/access-tokens/
   
   Username: 

Local debian 27 failure; passed on rerun. Known flaky?

@vvoland
Copy link
Collaborator

vvoland commented Sep 24, 2025

Hmm havent seen that one before, perhaps related to #6463?

@vvoland vvoland added this to the 28.5.0 milestone Sep 24, 2025
@vvoland vvoland merged commit a2d7989 into docker:28.x Sep 24, 2025
114 of 126 checks passed
@austinvazquez austinvazquez deleted the vendor-docker-docker-28.x branch September 24, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants