Skip to content

cli/streams: Out, In: preserve original os.File when available#6906

Merged
vvoland merged 1 commit intodocker:masterfrom
thaJeztah:stream_preserve_file
Apr 3, 2026
Merged

cli/streams: Out, In: preserve original os.File when available#6906
vvoland merged 1 commit intodocker:masterfrom
thaJeztah:stream_preserve_file

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 2, 2026

Preserve the original os.File, if available, and add a File() method
to return it did
*

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/streams: Out, In: preserve original os.File when available

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/streams/stream.go 0.00% 5 Missing ⚠️
cli/streams/in.go 0.00% 2 Missing ⚠️
cli/streams/out.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah force-pushed the stream_preserve_file branch 2 times, most recently from 5b95881 to 937de64 Compare April 2, 2026 16:35
Preserve the original *os.File, if available, and add a File() method
to return it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the stream_preserve_file branch from 937de64 to 94d4929 Compare April 2, 2026 18:52
@thaJeztah thaJeztah marked this pull request as ready for review April 2, 2026 18:52
@thaJeztah thaJeztah added kind/enhancement status/2-code-review area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK impact/changelog labels Apr 2, 2026
@thaJeztah thaJeztah modified the milestones: 29.5.0, 29.4.0 Apr 2, 2026
@vvoland vvoland merged commit 72beec9 into docker:master Apr 3, 2026
106 of 110 checks passed
@thaJeztah thaJeztah deleted the stream_preserve_file branch April 3, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/enhancement status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants