pass authprovider to buildkit session#1651
Conversation
|
@tonistiigi could you please confirm this is the correct way? |
c770dbf to
13b9341
Compare
gtardif
left a comment
There was a problem hiding this comment.
LGTM, Just pending @tonistiigi confirmation
|
go.mod is killing me ... |
Yes, both are needed. |
|
dependency issue: 1.4 -> 1.5 containerd updated I can't find any possible workaround here 😱 |
52aa391 to
964a548
Compare
| replace github.com/jaguilar/vt100 => github.com/tonistiigi/vt100 v0.0.0-20190402012908-ad4c4a574305 | ||
|
|
||
| // see https://github.com/helm/helm/pull/9675 | ||
| replace helm.sh/helm/v3 => github.com/ndeloof/helm/v3 v3.1.0-rc.1.0.20210507084602-d0ceda767d95 |
There was a problem hiding this comment.
A quick comment to explain this hack would be useful in the future...
gtardif
left a comment
There was a problem hiding this comment.
LGTM with nit (comment on go mod replace)
…rameter Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
What I did
Aligned compose build code with https://github.com/docker/buildx/blob/master/commands/build.go
Related issue
#1545