feat: resolve ref+ secret references in environment values#13822
Open
johan-nilsson-82 wants to merge 1 commit into
Open
feat: resolve ref+ secret references in environment values#13822johan-nilsson-82 wants to merge 1 commit into
johan-nilsson-82 wants to merge 1 commit into
Conversation
johan-nilsson-82
force-pushed
the
13821-ref-secret-resolution
branch
6 times, most recently
from
8c04d3d to
c8ff6f4
Compare
Add support for resolving secret references in service environment values using the ref+openbao://path#/key URI scheme, compatible with the convention established by helmfile/vals and ArgoCD Vault Plugin. Supported backend: - ref+openbao:// (OpenBao KV v2) The implementation uses a pluggable resolver interface (SecretResolver), making it straightforward to add new backends without modifying existing code. Secrets are resolved at project load time, after interpolation but before container creation. Authentication is handled via standard environment variables (BAO_ADDR, BAO_TOKEN, BAO_CACERT, BAO_SKIP_VERIFY). Closes docker#13821 Signed-off-by: Johan Nilsson <johan.nilsson.82@gmail.com>
johan-nilsson-82
force-pushed
the
13821-ref-secret-resolution
branch
from
c8ff6f4 to
ae994fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for resolving
ref+openbao://secret references in service environment values.The implementation resolves references at project load time using the OpenBao API client.
Currently this supports OpenBao KV v2-style secret paths.
Related issue
Closes #13821