ci: fix docs-upstream workflow#13912
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the docs-upstream GitHub Actions workflow to run the upstream validation reusable workflow from docker/docs using the main branch ref instead of a pinned commit SHA, aiming to validate against the latest upstream docs changes.
Changes:
- Switch
docker/docs/.github/workflows/validate-upstream.ymlreference from a pinned SHA to@main. - Add a
zizmorignore annotation for the unpinned reusable-workflow reference.
|
|
||
| validate: | ||
| uses: docker/docs/.github/workflows/validate-upstream.yml@00aefd5eae73898c4d3bcd7a6fe95a039293706b # main 2026-03-24 | ||
| uses: docker/docs/.github/workflows/validate-upstream.yml@main # zizmor: ignore[unpinned-uses] needs to validate against latest docs changes |
There was a problem hiding this comment.
That's why we have an exception it needs to run against latest changes
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The single-line change replaces a stale SHA-pinned reusable workflow reference (docker/docs/.github/workflows/validate-upstream.yml@00aefd5eae73898c4d3bcd7a6fe95a039293706b) with a floating @main reference. The deviation from the pinning policy is explicitly acknowledged and suppressed with # zizmor: ignore[unpinned-uses], with a clear rationale inline. No logic errors, broken step wiring, or YAML syntax issues are introduced. The change is intentional and correctly fixes the broken docs-upstream validation workflow.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
related to #13909