Don't pin versions in setup.py install_requires#367
Merged
d11wtq merged 1 commit intodocker:masterfrom Aug 4, 2014
Merged
Conversation
|
Looks like an improvement, but could you specify ranges, so we don't accidentally go up a major/minor version? e.g. |
|
Correction - re-reading http://semver.org, it should be OK to go up a minor version. Assuming all our dependencies' authors are well-behaved, which is by no means a guarantee, it should be: |
Author
|
Ya, that sounds good. I'll make this change |
|
Thinking about it, it's actually specified in Semver that before 1.0 "anything may change at any time", but locking to the minor version for 0.x packages is probably safe. Could you update accordingly for docopt, texttable, websocket-client and dockerpty? After that, and if you can squash it into one commit, LGTM. |
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
|
LGTM |
|
LGTM. |
d11wtq
added a commit
that referenced
this pull request
Aug 4, 2014
Don't pin versions in setup.py install_requires
|
Indeed it was, thanks 👍 |
|
Ugh, wrong issue. |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Don't pin versions in setup.py install_requires Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
Fix typo in CONTRIBUTING.md
infraAnchor
pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
Signed-off-by: Ben Kochie <superq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #366
Discussion in that issue,
Reference: https://caremad.io/blog/setup-vs-requirement/