This repository was archived by the owner on Mar 11, 2020. It is now read-only.
Merged
Conversation
fix the epoll fd leak (cherry picked from commit 2b08c55) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit 2c1d2e2) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
This patch handles case c) in moby/moby#31487 (c) A request cannot be added to 's.tasks' because the queue is full. case b) isn't fixable at this point case there's no way to cancel stuff from a channel since channels aren't context aware (yet?). Parallelizing tasks handling isn't easily doable either. Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit b812857) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
This PR containerd#930 ignored SIGPIPE signals but we aren't actually subscribed to receive them (and ignore them). This patch adds the missing piece by subscribing to receive SIGPIPE(s). Signed-off-by: Antonio Murdaca <runcom@redhat.com> (cherry picked from commit 6a7b7d2) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
kill shim will send SIGKILL to its children, but if the container is paused, the container doesn't response to the signal, this cause the containerd block and fail to start next time. Signed-off-by: Lei Jitang <leijitang@huawei.com> (cherry picked from commit b2a80cf) Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
vieux
reviewed
Aug 7, 2017
| ooms: make(chan string, 1024), | ||
| } | ||
| fd, err := archutils.EpollCreate1(0) | ||
| fd, err := archutils.EpollCreate1(syscall.EPOLL_CLOEXEC) |
There was a problem hiding this comment.
the value 0x80000 is the change expected ?
|
SGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This port over the issue listed here (originally for 17.06) to the 17.03 branch,
The 3 issues below were NOT included though (harder to make a proper merge, and they're adding features, not fixing things):