Telemetry should send tool and token events#104
Merged
derekmisler merged 2 commits intodocker:mainfrom Sep 5, 2025
Merged
Conversation
e237297 to
debfcc4
Compare
c250029 to
4f9f67e
Compare
0b1c6bc to
ab13d90
Compare
dgageot
approved these changes
Sep 5, 2025
derekmisler
commented
Sep 5, 2025
b31631b to
4757ff5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the telemetry system to use synchronous event processing instead of asynchronous background processing. The change simplifies the telemetry client by removing event queues, background goroutines, and async processing infrastructure.
- Switches from asynchronous event queuing to synchronous event processing
- Simplifies client initialization and removes shutdown/cleanup complexity
- Updates telemetry configuration to default to enabled instead of requiring explicit opt-in
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/telemetry/utils.go | Changes telemetry default behavior to enabled and simplifies the enable/disable logic |
| internal/telemetry/types.go | Removes async processing types and replaces slog.Logger with custom telemetryLogger |
| internal/telemetry/telemetry_test.go | Updates tests to work with synchronous processing and simplified HTTP client mocking |
| internal/telemetry/http.go | Updates logging messages to use consistent event_type field names |
| internal/telemetry/global.go | Removes deprecated global client setter and updates initialization logging |
| internal/telemetry/events.go | Replaces async event queuing with direct synchronous event processing |
| internal/telemetry/client.go | Major refactor: removes async processing, adds telemetryLogger wrapper, simplifies client creation |
| docs/TELEMETRY.md | Updates documentation to reflect synchronous processing |
| Taskfile.yml | Removes TELEMETRY_ENABLED build argument since telemetry now defaults to enabled |
| Dockerfile | Removes TELEMETRY_ENABLED build argument from Docker builds |
| .github/workflows/ci.yml | Removes TELEMETRY_ENABLED environment variable from CI workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #98