Skip to content

Telemetry should send tool and token events#104

Merged
derekmisler merged 2 commits intodocker:mainfrom
derekmisler:bug---telemetry-should-send-tool-and-token-event
Sep 5, 2025
Merged

Telemetry should send tool and token events#104
derekmisler merged 2 commits intodocker:mainfrom
derekmisler:bug---telemetry-should-send-tool-and-token-event

Conversation

@derekmisler
Copy link
Copy Markdown
Contributor

Resolves #98

@derekmisler derekmisler self-assigned this Sep 4, 2025
@derekmisler derekmisler force-pushed the bug---telemetry-should-send-tool-and-token-event branch from e237297 to debfcc4 Compare September 4, 2025 17:40
@derekmisler derekmisler requested a review from Copilot September 4, 2025 17:40

This comment was marked as outdated.

@derekmisler derekmisler requested a review from Copilot September 4, 2025 17:52

This comment was marked as resolved.

@derekmisler derekmisler requested review from a team and removed request for a team September 4, 2025 17:56
@derekmisler derekmisler marked this pull request as ready for review September 4, 2025 18:06
@derekmisler derekmisler marked this pull request as draft September 4, 2025 19:54
@derekmisler derekmisler force-pushed the bug---telemetry-should-send-tool-and-token-event branch from c250029 to 4f9f67e Compare September 4, 2025 20:45
@derekmisler derekmisler marked this pull request as ready for review September 4, 2025 20:48
@derekmisler derekmisler force-pushed the bug---telemetry-should-send-tool-and-token-event branch from 0b1c6bc to ab13d90 Compare September 5, 2025 02:20
Comment thread internal/telemetry/client.go Outdated
Comment thread internal/telemetry/types.go Outdated
Comment thread internal/telemetry/events.go Outdated
Comment thread internal/telemetry/client.go Outdated
Comment thread internal/telemetry/client.go Outdated
@derekmisler derekmisler force-pushed the bug---telemetry-should-send-tool-and-token-event branch from b31631b to 4757ff5 Compare September 5, 2025 14:43
@derekmisler derekmisler requested a review from Copilot September 5, 2025 14:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the telemetry system to use synchronous event processing instead of asynchronous background processing. The change simplifies the telemetry client by removing event queues, background goroutines, and async processing infrastructure.

  • Switches from asynchronous event queuing to synchronous event processing
  • Simplifies client initialization and removes shutdown/cleanup complexity
  • Updates telemetry configuration to default to enabled instead of requiring explicit opt-in

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/telemetry/utils.go Changes telemetry default behavior to enabled and simplifies the enable/disable logic
internal/telemetry/types.go Removes async processing types and replaces slog.Logger with custom telemetryLogger
internal/telemetry/telemetry_test.go Updates tests to work with synchronous processing and simplified HTTP client mocking
internal/telemetry/http.go Updates logging messages to use consistent event_type field names
internal/telemetry/global.go Removes deprecated global client setter and updates initialization logging
internal/telemetry/events.go Replaces async event queuing with direct synchronous event processing
internal/telemetry/client.go Major refactor: removes async processing, adds telemetryLogger wrapper, simplifies client creation
docs/TELEMETRY.md Updates documentation to reflect synchronous processing
Taskfile.yml Removes TELEMETRY_ENABLED build argument since telemetry now defaults to enabled
Dockerfile Removes TELEMETRY_ENABLED build argument from Docker builds
.github/workflows/ci.yml Removes TELEMETRY_ENABLED environment variable from CI workflows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread internal/telemetry/utils.go
Comment thread internal/telemetry/client.go
Comment thread internal/telemetry/client.go
@derekmisler derekmisler merged commit 0f23870 into docker:main Sep 5, 2025
4 checks passed
@derekmisler derekmisler deleted the bug---telemetry-should-send-tool-and-token-event branch September 5, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Telemetry should send tool and token events

3 participants