Add the session store to the runtime#1056
Merged
dgageot merged 1 commit intodocker:mainfrom Dec 9, 2025
Merged
Conversation
rumpl
force-pushed
the
runtime-session-store
branch
3 times, most recently
from
e190585 to
3eabf4c
Compare
dgageot
reviewed
Dec 9, 2025
| // Start a recording AI proxy to record and replay traffic. | ||
| svr, _ := startRecordingAIProxy(t) | ||
| args = append(args, "--models-gateway", svr.URL) | ||
| args = append(args, "--models-gateway", svr.URL, "--session-db", "/tmp/session.db") |
Member
There was a problem hiding this comment.
What happens when tests run concurrently?
Member
Author
There was a problem hiding this comment.
The store should be able to handle concurrent requests so this is fine.
dgageot
reviewed
Dec 9, 2025
| } | ||
|
|
||
| type InMemorySessionStore struct { | ||
| sessions map[string]*Session |
Member
There was a problem hiding this comment.
Can this store be shared between multiple sessions? Should it be synchronised?
rumpl
force-pushed
the
runtime-session-store
branch
from
3eabf4c to
d76f278
Compare
The runtime will save intermediate messages it gets during a loop Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
runtime-session-store
branch
from
d76f278 to
02daf90
Compare
dgageot
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime will save intermediate messages it gets during a loop