Add a "Meta" property to the tool results#1110
Merged
dgageot merged 3 commits intodocker:mainfrom Dec 16, 2025
Merged
Conversation
rumpl
commented
Dec 15, 2025
| ToolCall tools.ToolCall `json:"tool_call"` | ||
| ToolDefinition tools.Tool `json:"tool_definition"` | ||
| Response string `json:"response"` | ||
| Result *tools.ToolCallResult `json:"result,omitempty"` |
Member
Author
There was a problem hiding this comment.
This one is weird... For now, at some point in the future we will be able to remove the Response, once no other parts depend on it
rumpl
changed the title
This makes it possible for the tools to send additional data that is not meant to be sent to the LLM. We use this in the case of the todo toolset to always send the current state of all of the todos. With this meta we no longer have to parse the arguments on the TUI side. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
dgageot
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for the tools to send additional data that is not meant to be sent to the LLM. We use this in the case of the todo toolset to always send the current state of all of the todos. With this meta we no longer have to parse the arguments on the TUI side.