Skip to content

Return an error if www-auth resource retuns unexpected status code #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumpl merged 1 commit into from
Dec 18, 2025
Merged

Return an error if www-auth resource retuns unexpected status code #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/tools/mcp/oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ func (t *oauthTransport) handleManagedOAuthFlow(ctx context.Context, authServer,
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNotFound {
return err
_, _ = io.ReadAll(resp.Body)
return errors.New("failed to fetch protected resource metadata")
}
var resourceMetadata protectedResourceMetadata
if resp.StatusCode == http.StatusOK {
Expand Down Expand Up @@ -390,7 +391,8 @@ func (t *oauthTransport) handleUnmanagedOAuthFlow(ctx context.Context, authServe
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNotFound {
return err
_, _ = io.ReadAll(resp.Body)
return errors.New("failed to fetch protected resource metadata")
}
var resourceMetadata protectedResourceMetadata
if resp.StatusCode == http.StatusOK {
Expand Down
Loading