fix(api): reject invalid resume confirmation with explicit error#1414
Merged
krissetto merged 3 commits intodocker:mainfrom Jan 21, 2026
Merged
fix(api): reject invalid resume confirmation with explicit error#1414krissetto merged 3 commits intodocker:mainfrom
krissetto merged 3 commits intodocker:mainfrom
Conversation
krissetto
reviewed
Jan 19, 2026
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
17c3d37 to
d15b5c2
Compare
krissetto
reviewed
Jan 20, 2026
Signed-off-by: pnkcaht <samzoovsk19@gmail.com>
krissetto
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added explicit validation for /resume confirmation values so invalid inputs (e.g. "garbage") are rejected early instead of causing opaque tool execution failures.
This ensures the agent reports a clear user error when a tool call is rejected, rather than surfacing a misleading (tool execution failed) message.
Related issue
Fixes #1376
Notes
Tests
Before
When calling /resume with an invalid confirmation value (e.g. "garbage"):
After
When calling /resume with an invalid confirmation value:
Screenshot
Below is a photo of the new return.