Detect parent process death via stdin EOF#1423
Merged
trungutt merged 2 commits intodocker:mainfrom Jan 20, 2026
Merged
Conversation
When cagent is spawned by a parent process with piped stdio, monitor stdin for EOF to detect when the parent dies. This ensures cagent shuts down gracefully instead of becoming an orphan process.
krissetto
reviewed
Jan 19, 2026
| func monitorStdin(cancel context.CancelFunc, stdin *os.File) { | ||
| buf := make([]byte, 1) | ||
| for { | ||
| n, err := stdin.Read(buf) |
Contributor
There was a problem hiding this comment.
nit: could this block the goroutine in other scenarios like normal shutdown if we don't check if the context has already been cancelled? probably not a big issue though since the proc should die anyway in most other scenarios
Contributor
Author
There was a problem hiding this comment.
I pushed a second commit
Pass context to monitorStdin and close stdin when context is cancelled. This unblocks the read and allows clean goroutine exit during normal shutdown (e.g., SIGTERM), not just when the parent process dies.
krissetto
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cagent is spawned by a parent process with piped stdio, monitor stdin for EOF to detect when the parent dies. This ensures cagent shuts down gracefully instead of becoming an orphan process.