Fix restoring style after style inline text#1457
Merged
dgageot merged 2 commits intodocker:mainfrom Jan 21, 2026
Merged
Conversation
If the markdown had a line like "Hello `there` beautiful", the "beautiful" text would have the default terminal style because there is a reset of styling after the code block, we fix this by reseting to normal text style when needed. Ran benchmarks, this adds only around 3 more allocs for small texts Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
dgageot
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the markdown had a line like "Hello
therebeautiful", the "beautiful" text would have the default terminal style because there is a reset of styling after the code block, we fix this by reseting to normal text style when needed.Ran benchmarks, this adds only around 3 more allocs for small texts