Skip to content

Don't go negative in tui dimensions in collapsed sidebar #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krissetto merged 1 commit into from
Feb 4, 2026
Merged

Don't go negative in tui dimensions in collapsed sidebar #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pkg/tui/page/chat/chat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,13 @@ const pendingSpinnerHeight = 3

// renderCollapsedSidebar renders the sidebar in collapsed mode (at top of screen).
func (p *chatPage) renderCollapsedSidebar(sl sidebarLayout) string {
// Guard against unset/invalid layout (can happen before WindowSizeMsg is received).
width := max(0, sl.innerWidth)
height := max(0, sl.sidebarHeight)
if width == 0 || height == 0 {
return ""
}

sidebarView := p.sidebar.View()
sidebarLines := strings.Split(sidebarView, "\n")

Expand All @@ -614,18 +621,18 @@ func (p *chatPage) renderCollapsedSidebar(sl sidebarLayout) string {
}

// Replace the last line with a subtle divider
divider := styles.FadingStyle.Render(strings.Repeat("─", sl.innerWidth))
if len(sidebarLines) >= sl.sidebarHeight {
sidebarLines[sl.sidebarHeight-1] = divider
divider := styles.FadingStyle.Render(strings.Repeat("─", width))
if len(sidebarLines) >= height {
sidebarLines[height-1] = divider
} else {
sidebarLines = append(sidebarLines, divider)
}

sidebarWithDivider := strings.Join(sidebarLines, "\n")

return lipgloss.NewStyle().
Width(sl.innerWidth).
Height(sl.sidebarHeight).
Width(width).
Height(height).
Align(lipgloss.Left, lipgloss.Top).
Render(sidebarWithDivider)
}
Expand Down
Loading