Refactor winget workflow to use wingetcreate CLI#1826
Merged
Conversation
Signed-off-by: Lorena Rangel <lorena.rangel@docker.com>
b7cedaa to
ea7aee9
Compare
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
ea7aee9 to
a39c6a3
Compare
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
68407e9 to
f6afe9d
Compare
Contributor
Author
|
Workflow tested here => PR created in winget to update to v1.23.5. |
trungutt
previously approved these changes
Feb 23, 2026
krissetto
reviewed
Feb 23, 2026
| token: ${{ steps.app-token.outputs.token }} | ||
| $Version = $ENV:VERSION | ||
| $DryRun = $ENV:DRY_RUN -eq 'true' | ||
| $PackageId = "Docker.Cagent" |
Contributor
There was a problem hiding this comment.
should we already start migrating to Docker.Agent, or is that better leftfor another moment?
Contributor
Author
There was a problem hiding this comment.
I'm planning this for a follow up, indeed, this is just fixing this workflow that had never been green before
(we'll need to create the Docker.Agent entry in winget first)
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
b4158d1 to
68823fb
Compare
trungutt
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #1825, allowing to test the winget release before merging the PR here