Enable bodyclose, makezero, and sqlclosecheck linters#2219
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 23, 2026
Merged
Conversation
Add three new linters to golangci-lint configuration and fix all reported issues: - bodyclose: ensure HTTP response bodies are closed in tests; add nolint for false positives (websocket upgrade, goroutine-deferred close) - makezero: use make+append instead of make+copy in hasCycle - sqlclosecheck: use defer rows.Close() instead of manual close calls Assisted-By: docker-agent
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR cleanly enables three new golangci-lint linters and fixes all reported issues:
- ✅ bodyclose: Adds
defer resp.Body.Close()in test files, with appropriate//nolintdirectives for websocket upgrades and goroutine-deferred closes - ✅ makezero: Optimizes slice initialization in
hasCyclefunction (make+append instead of make+copy) - ✅ sqlclosecheck: Consolidates manual
rows.Close()calls into a singledefer rows.Close()statement, properly placed after error checking
All changes are linter-driven improvements with no bugs introduced. The defer rows.Close() placement is correct (after error checks), and the slice optimization is functionally equivalent.
gtardif
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three new linters to golangci-lint configuration and fix all reported issues:
hasCycledefer rows.Close()instead of manual close calls