Fix nil pointer dereference in BM25Strategy.watchLoop during session teardown#2334
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 7, 2026
Conversation
…teardown Capture the watcher reference as a local variable at goroutine start to avoid racing with Close() which sets s.watcher = nil under watcherMu. Also add a nil guard before calling addPathToWatcher on Create events. This matches the fix already applied to VectorStore.watchLoop. Assisted-By: docker-agent
aheritier
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture the watcher reference as a local variable at goroutine start to avoid racing with Close() which sets s.watcher = nil under watcherMu. Also add a nil guard before calling addPathToWatcher on Create events.
This matches the fix already applied to VectorStore.watchLoop.
Assisted-By: docker-agent