Fix skill frontmatter parsing when description contains a colon#2401
Merged
dgageot merged 1 commit intodocker:mainfrom Apr 13, 2026
Merged
Conversation
Replace the YAML parser in parseFrontmatter with simple line-by-line parsing that splits on the first ": ". The YAML parser rejected unquoted colons in values (e.g. "Usage: run this"), which caused skills with such descriptions to silently fail to load. Also simplify the Skill struct by removing unused yaml struct tags and the dead stringOrList type, since YAML unmarshaling is no longer used for local skill frontmatter. Fixes docker#2393 Assisted-By: docker-agent
rumpl
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the YAML parser in
parseFrontmatterwith simple line-by-line parsing that splits on the first:. The YAML parser rejected unquoted colons in values (e.g.Usage: run this), which caused skills with such descriptions to silently fail to load.Changes
pkg/skills/skills.go: Replaceyaml.Unmarshalwith a line-by-line parser that handles colons in values naturally. Remove the unusedstringOrListtype,UnmarshalYAMLmethod, yaml struct tags, andgo-yamlimport.pkg/skills/skills_test.go: Add test cases for colons in descriptions and quoted allowed-tools list items.Fixes #2393